Qualify Const Member Functions in GroupDataProvider#72065
Merged
mergify[bot] merged 2 commits intoMay 15, 2026
Conversation
for more information, see https://pre-commit.ci
tcarmelveilleux
approved these changes
May 15, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves const-correctness by adding the "const" qualifier to several getter methods within the GroupDataProvider interface, its implementation GroupDataProviderImpl, and the MockGroupDataProvider test class. Specifically, methods such as GetMaxGroupsPerFabric, IsGroupcastEnabled, getMaxMembershipCount, and getMaxMcastAddrCount are now marked as const. I have no feedback to provide.
|
PR #72065: Size comparison from fa18120 to ec3c441 Full report (33 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72065 +/- ##
=======================================
Coverage 54.89% 54.89%
=======================================
Files 1619 1619
Lines 110414 110414
Branches 13493 13493
=======================================
Hits 60609 60609
Misses 49805 49805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
soares-sergio
approved these changes
May 15, 2026
soares-sergio
added
the
sdk-maintainer-approved
jmartinez-silabs
approved these changes
May 15, 2026
pankore
pushed a commit
to pankore/connectedhomeip
that referenced
this pull request
May 22, 2026
* make const member functions * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR qualifies some const member functions. This change stems from a request to keep
GetMaxGroupsPerFabric()as a const member function, as this was unintentionally removed as part of #72047. To do this, the functions called withinGetMaxGroupsPerFabric()were made const too.Testing