You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the VS Code launch configuration for the Tizen LightingApp to target the aarch64 architecture, adjusting paths, debugger settings, and setup commands. Feedback on these changes suggests removing the SIGINT signal handling configuration, as it prevents the debugger from pausing execution, and removing the redundant set solib-absolute-prefix command since set sysroot is already defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update VS Code launch config to debug on remote Tizen device.
Set arch to 64 bit.
Testing
Run Tizen 10 on Raspberry Pi 4. Install
gdbserverCompile the
lighting-appfor Tizen, and install it on device withsdb.sdb shellSet VS code breakpoints on
void LightingManager::Set(bool aOn)Commission the
chip-tooland toggle lighing.Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See:
Pull Request Guidelines