Remove kProtocolCodeSessionNotFound constant#72363
Merged
Merged
Conversation
This protocol code is not defined in specification, so lets better remove it before anyone tries to use it
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
Alami-Amine
approved these changes
Jun 3, 2026
|
PR #72363: Size comparison from f1767a8 to 44583ef Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72363 +/- ##
=======================================
Coverage 55.61% 55.61%
=======================================
Files 1630 1630
Lines 111146 111146
Branches 13397 13397
=======================================
Hits 61812 61812
Misses 49334 49334 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmartinez-silabs
approved these changes
Jun 3, 2026
andy31415
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes a protocol code which is not defined in specification. Better remove it before anyone tries to use it.
Testing
unused code anyway, so safe to remove