Update tizen_gdbserver_run script for tizen 10#72364
Open
antonijakubiak-samsung wants to merge 5 commits into
Open
Update tizen_gdbserver_run script for tizen 10#72364antonijakubiak-samsung wants to merge 5 commits into
antonijakubiak-samsung wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Tizen gdbserver runner script to launch applications in native suspension debug mode and manually attach gdbserver to the process PID. Feedback highlights two main improvements: replacing the non-portable grep -oP with a more portable sed command to extract the PID on macOS hosts, and conditionally appending $APP_ARGS to avoid trailing double-dashes when no arguments are provided.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
PR #72364: Size comparison from f1767a8 to a139307 Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72364 +/- ##
==========================================
+ Coverage 55.55% 55.61% +0.05%
==========================================
Files 1630 1630
Lines 111147 111146 -1
Branches 13410 13397 -13
==========================================
+ Hits 61752 61812 +60
+ Misses 49395 49334 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Tizen remote debugging helper script (
tizen_gdbserver_run.sh)__DLP_DEBUG_ARG__and__AUL_SDK__) with the officialapp_launcher --debug --startAPI to ensure compatibility with Tizen 10.0 images.gdbserverto the suspended process.Testing
Run application in debug mode:
Run debugger:
Setup debugger:
Trigger breakpoint:
Results in GDB:
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See:
Pull Request Guidelines