[WiFiPAF] Fix the potential vulnerability issues. (backport #43031)#72371
Open
mergify[bot] wants to merge 1 commit into
Open
[WiFiPAF] Fix the potential vulnerability issues. (backport #43031)#72371mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
* Fix the potential vulnerability issues.
- underflow issue if mWindowSize is small (or 0)
- Memory leak in ReorderQueue if connection drops unexpectedly
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
* Restyled by clang-format
* Update src/wifipaf/WiFiPAFConfig.h
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Refine the comment based on Gemini’s suggested wording
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
* Add more information to the new defined macro
Replace #error with static_assert
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
* Restyled by clang-format
---------
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Amine Alami <43780877+Alami-Amine@users.noreply.github.com>
(cherry picked from commit c3480ff)
mergify
Bot
added
the
backport-v1.4.2-branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the potential issues:
- underflow issue if mWindowSize is small (or equal to 0)
- Memory leak in ReorderQueue if connection drops unexpectedly
Testing
This is an automatic backport of pull request #43031 done by [Mergify](https://mergify.com).