Skip to content

[IM Engine] add missing nullptr checks for IterateSubscriptions (backport #43625)#72380

Open
mergify[bot] wants to merge 1 commit into
v1.5-branchfrom
mergify/bp/v1.5-branch/pr-43625
Open

[IM Engine] add missing nullptr checks for IterateSubscriptions (backport #43625)#72380
mergify[bot] wants to merge 1 commit into
v1.5-branchfrom
mergify/bp/v1.5-branch/pr-43625

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Jun 3, 2026

Summary

  • 4 null-checks were missing in SubscriptionResumption code paths in the InteractionModel Engine.
  • They all relate to IterateSubscriptions() which can fail to allocate an Iterator from ObjectPool when a fixed-size pool is used and two iterators have already been allocated.

Testing

  • Added unit test cases for a couple of the null checks

This is an automatic backport of pull request #43625 done by [Mergify](https://mergify.com).

* [IM Engine] add missing nullptr checks for IterateSubscriptions

* Adding unit tests

* integrate copilot comments

* test adapt to integrated comment

* Add ChipErrorLog when failed to allocate iterator

(cherry picked from commit dfcd5ce)
@mergify mergify Bot added the backport-v1.5-branch Backport PR targeting v1.5-branch, created by Mergify label Jun 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

PR #72380: Size comparison from 44aaaba to e5eaefa

Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section 44aaaba e5eaefa change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1105954 1105954 0 0.0
RAM 178938 178938 0 0.0
bl702 lighting-app bl702+eth FLASH 661028 661028 0 0.0
RAM 135025 135025 0 0.0
bl702+wifi FLASH 836622 836622 0 0.0
RAM 124461 124461 0 0.0
bl706+mfd+rpc+littlefs FLASH 1070278 1070278 0 0.0
RAM 117333 117333 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 899112 899112 0 0.0
RAM 105612 105612 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 983024 983024 0 0.0
RAM 109812 109812 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 770516 770516 0 0.0
RAM 103368 103368 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 782384 782384 0 0.0
RAM 108544 108544 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 728296 728296 0 0.0
RAM 97428 97428 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 712772 712772 0 0.0
RAM 97644 97644 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 554874 554874 0 0.0
RAM 205808 205808 0 0.0
lock CC3235SF_LAUNCHXL FLASH 587762 587762 0 0.0
RAM 205912 205912 0 0.0
efr32 lock-app BRD4187C FLASH 963200 963272 72 0.0
RAM 123604 123604 0 0.0
window-app BRD4187C FLASH 1058020 1058060 40 0.0
RAM 119832 119832 0 0.0
lock-app BRD4338a FLASH 757000 757080 80 0.0
RAM 254204 254204 0 0.0
esp32 all-clusters-app c3devkit DRAM 97788 97788 0 0.0
FLASH 1579530 1579636 106 0.0
IRAM 93514 93514 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 929172 929272 100 0.0
RAM 161458 161458 0 0.0
nxp contact mcxw71+release FLASH 740688 740776 88 0.0
RAM 66952 66952 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1688340 1688340 0 0.0
RAM 214060 214060 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1593164 1593164 0 0.0
RAM 211188 211188 0 0.0
light cy8ckit_062s2_43012 FLASH 1460468 1460468 0 0.0
RAM 197808 197808 0 0.0
lock cy8ckit_062s2_43012 FLASH 1493188 1493188 0 0.0
RAM 225528 225528 0 0.0
qpg lighting-app qpg6200+debug FLASH 836720 836824 104 0.0
RAM 127776 127776 0 0.0
lock-app qpg6200+debug FLASH 774380 774484 104 0.0
RAM 118744 118744 0 0.0
realtek light-switch-app rtl8777g FLASH 706136 706136 0 0.0
RAM 106980 106980 0 0.0
lighting-app rtl8777g FLASH 757024 757024 0 0.0
RAM 127304 127304 0 0.0
stm32 light STM32WB5MM-DK FLASH 469896 469896 0 0.0
RAM 141360 141360 0 0.0
telink light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 797072 797072 0 0.0
RAM 41032 41032 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 725502 725502 0 0.0
RAM 34636 34636 0 0.0
bridge-app tl7218x FLASH 710580 710580 0 0.0
RAM 90608 90608 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 788274 788274 0 0.0
RAM 93708 93708 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 715356 715356 0 0.0
RAM 51904 51904 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602602 602602 0 0.0
RAM 108680 108680 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 820910 820910 0 0.0
RAM 92104 92104 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 748652 748652 0 0.0
RAM 70944 70944 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app backport-v1.5-branch Backport PR targeting v1.5-branch, created by Mergify tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant