[IM Engine] add missing nullptr checks for IterateSubscriptions (backport #43625)#72380
Open
mergify[bot] wants to merge 1 commit into
Open
[IM Engine] add missing nullptr checks for IterateSubscriptions (backport #43625)#72380mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
* [IM Engine] add missing nullptr checks for IterateSubscriptions * Adding unit tests * integrate copilot comments * test adapt to integrated comment * Add ChipErrorLog when failed to allocate iterator (cherry picked from commit dfcd5ce)
|
PR #72380: Size comparison from 44aaaba to e5eaefa Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubscriptionResumptioncode paths in the InteractionModel Engine.IterateSubscriptions()which can fail to allocate an Iterator from ObjectPool when a fixed-size pool is used and two iterators have already been allocated.Testing
This is an automatic backport of pull request #43625 done by [Mergify](https://mergify.com).