[TLV Read] - fix read resetting empty TLV data (backport #43182)#72389
Open
mergify[bot] wants to merge 1 commit into
Open
[TLV Read] - fix read resetting empty TLV data (backport #43182)#72389mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
* Fix TLV reading of empty data. * Update LSID. * Cleanup test. (cherry picked from commit 9edc95e)
|
PR #72389: Size comparison from 09d0453 to 5fec415 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This results in checks for data pointer to early return and were failing to reset the CharSpan to an empty value. This breaks any code that assumes a successful read will reset the data (which seems reasonable).
We mostly did not see it because we often initialize
CharSpanand then read. Correctness-wise though, a successfull read should update the read target.Testing
CI tests updated to a test that would catch this bug (tested that it would fail before the fix)
This is an automatic backport of pull request #43182 done by Mergify.