Type Check for Feature Map, Device Basic Composition#72392
Open
lpbeliveau-silabs wants to merge 1 commit into
Open
Type Check for Feature Map, Device Basic Composition#72392lpbeliveau-silabs wants to merge 1 commit into
lpbeliveau-silabs wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the TC_DeviceBasicComposition.py test script to handle cases where reading or decoding the FEATURE_MAP attribute fails. Specifically, it checks if feature_map is an instance of ValueDecodeFailure, records an error, and skips further processing for that cluster. I have no additional feedback to provide as there are no review comments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72392 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 1630 1630
Lines 111223 111223
Branches 13409 13409
=======================================
Hits 61812 61812
Misses 49411 49411 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #72392: Size comparison from 9cf1485 to 8ba73ba Full report (25 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32)
|
jepenven-silabs
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a check for a more descriptive error when there is an error trying to read the feature map in device basic composition test.
Related issues
na
Testing
ran failing test locally.
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See:
Pull Request Guidelines