[NXP] PSA and SDK 26.03 00 support#72460
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates cryptographic operations to the Platform Security Architecture (PSA) and introduces EdgeLock 2GO (EL2GO) factory data support across NXP platforms, including the implementation of platform-specific key allocators and updated factory data providers. The review feedback highlights several critical issues: syntax errors with the TEMPORARY_RETURN_IGNORED macro, a typo in a Kconfig configuration, and potential security vulnerabilities including out-of-bounds reads in TLV parsing and an integer overflow in ParseEl2GoBlob. Additionally, the reviewer noted memory leaks on error paths, missing null-pointer checks for memory allocations, insufficient validation of factory data header sizes, and the unsafe use of assert(0) in production code.
9058698 to
4dc33fd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72460 +/- ##
=======================================
Coverage 56.06% 56.06%
=======================================
Files 1640 1640
Lines 112575 112575
Branches 13353 13353
=======================================
Hits 63110 63110
Misses 49465 49465 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
PR #72460: Size comparison from c11ecba to 950efdf Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
|
PR #72460: Size comparison from c11ecba to 1237c01 Full report (21 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32)
|
1237c01 to
d8348b9
Compare
|
PR #72460: Size comparison from c09c859 to d8348b9 Full report (25 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32)
|
|
PR #72460: Size comparison from ef97353 to 0d7e403 Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
0d7e403 to
bbca9f4
Compare
|
Approval granted as the content has already been reviewed within NXP. |
|
PR #72460: Size comparison from b253aab to bbca9f4 Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
|
@Martin-NXP you have to fix restyle (it seems precommi-ci has no permissions to update your fork) |
@andy31415 Yes, for now, our fork doesn't provide the necessary permissions (permission requested). In the meantime, I ran the pre-commit script locally (as I did in the opened PR #72284: check is passing now), but the problem persists on the actual PR. I think I have to rebase this PR once the permission will be given. For the other PR, is it possible to have non-NXP review as all checks are passing now ? |
bbca9f4 to
603a531
Compare
|
PR #72460: Size comparison from 85bfccd to 603a531 Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
603a531 to
03274f9
Compare
|
PR #72460: Size comparison from 426a3b4 to 03274f9 Full report (25 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32)
|
03274f9 to
75b4e66
Compare
|
PR #72460: Size comparison from ace3ccc to 75b4e66 Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
75b4e66 to
1cd39f7
Compare
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Signed-off-by: Doru-Cristian Gucea <doru-cristian.gucea@nxp.com>
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
|
PR #72460: Size comparison from ff91326 to 1cd39f7 Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
|
Tick the box to add this pull request to the merge queue (same as
|
Summary
Migrates all NXP FreeRTOS platforms (MCXW72, RW61x, RT1060, RT1170) to use PSA Crypto as the default cryptographic backend, and updates the build infrastructure for NXP MCUXpresso SDK 26.03.00.
New NXP SDK didn't support any more mbedtls 2.X so we have to switch all NXP platforms to PSA layer.
PR is quite large due to the fact that most changes are interdependent, preventing it from being split into smaller PRs
Testing
Internal validation for all freertos platforms to validate new SDK support. Run crypto unit tests to validate PSA switch.