CommissioningProxy PR1: add cluster definition and generated code#72600
Merged
mergify[bot] merged 6 commits intoJun 23, 2026
Conversation
github-actions
Bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the CommissioningProxy cluster and the Commissioning By Proxy device type, along with their corresponding XML definitions, Java/Kotlin controller implementations, Python bindings, and Darwin framework support. The review feedback highlights critical robustness improvements needed in the Python ScriptBinding implementation (ChipDeviceController-ScriptBinding.cpp) to prevent potential crashes and hangs. Specifically, it recommends adding defensive null checks for proxyTransport and refactoring error handling in OnResponse and OnError to ensure proper error propagation without double-calling the pairing delegate. Additionally, the CachedResults attribute should be added to the Commissioning Proxy attribute lists in zcl.json and zcl-with-test-extensions.json to maintain consistency with the cluster XML definition.
andy31415
reviewed
Jun 16, 2026
andy31415
reviewed
Jun 16, 2026
|
PR #72600: Size comparison from bfec9c8 to 7f88dba Full report (10 builds for cc13x4_26x4, cc32xx, nrfconnect, realtek, stm32)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72600 +/- ##
=======================================
Coverage 56.74% 56.74%
=======================================
Files 1630 1630
Lines 112290 112290
Branches 13114 13114
=======================================
Hits 63719 63719
Misses 48571 48571 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
PR #72600: Size comparison from bfec9c8 to 678b127 Full report (21 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32)
|
|
PR #72600: Size comparison from bfec9c8 to 9bd1d68 Full report (24 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, psoc6, qpg, realtek, stm32)
|
Add the generated registration for commissioning-proxy-cluster.xml that was missing from the codegen config: - zap_cluster_list.json: add COMMISSIONING_PROXY_CLUSTER (empty server dir; server entry deferred to the cluster-impl PR) - tests.yaml: add the XML to the CI "Validate that xml are parsable" list - commissioning-proxy-cluster.xml: regenerate header with attribute=in-progress; Git provenance now clean (no -dirty)
simonhmorris1
changed the title
|
PR #72600: Size comparison from 10dc250 to b871472 Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Jun 23, 2026
andy31415
added
the
sdk-maintainer-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First in a series of PRs introducing the Commissioning Proxy feature. This PR adds only the data model definition of the new
CommissioningProxycluster (0x0455) and theCommissioningByProxydevice type (0x0092), together with everything generated from that definition. It introduces no server logic and no runtime behavior — those follow in subsequent PRs (cluster server implementation, example app, chip-tool/commissioner integration, and certification tests).What's included:
commissioning-proxy-cluster.xml, plus registration inzcl.json,zcl-with-test-extensions.json,config-data.yaml, andzap_cluster_list.json.CommissioningByProxy(0x0092) added tomatter-devices.xml.zzz_generated/app-common(cluster/attribute/command/event IDs, cluster-objects, enums, per-cluster metadata), the controller IDL (controller-clusters.matter), chip-tool command + logging code, the Darwin framework bindings, the Java/Kotlin and Python controller bindings, and thedocs/ids_and_codes/zap_clusters.mdcluster index.Splitting the feature this way keeps the large-but-mechanical generated diff isolated from hand-written logic, so the following PRs stay small and reviewable. The
zap_cluster_list.jsonserver-directory mapping is deliberately deferred to the cluster-server PR, where that directory actually exists.Testing
chip-tooland the Linuxlighting-appcompile against this branch in isolation, confirming the generated cluster code and the updatedapp-commonheaders build with no dependency on any later PR in the series.