v1.6.1 Initial Release of Data Model#72622
Merged
Merged
Conversation
+ add constraint string to diff summary
github-actions
Bot
added
documentation
pullapprove
Bot
removed
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive set of XML data model definitions for various Matter clusters under version 1.6.1. The review identified a few schema and constraint issues in the newly added files: the EnergyPriorities list attribute in EnergyPreference.xml incorrectly uses a scalar <allowed> constraint instead of a list size constraint; the RecoveryIdentifier octet string attribute in GeneralCommissioningCluster.xml has an invalid integer default value of 0; and the deprecated SecurityLevel attribute in DoorLock.xml is missing its type definition.
|
PR #72622: Size comparison from 3298d54 to 9db2536 Full report (24 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, psoc6, qpg, realtek, stm32)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72622 +/- ##
=======================================
Coverage 56.19% 56.19%
=======================================
Files 1644 1644
Lines 113050 113050
Branches 13362 13361 -1
=======================================
+ Hits 63527 63529 +2
+ Misses 49523 49521 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
documentation
|
PR #72622: Size comparison from 3298d54 to 84d7d51 Full report (24 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, psoc6, qpg, realtek, stm32)
|
|
PR #72622: Size comparison from 3298d54 to 0163029 Increases above 0.2%:
Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
|
PR #72622: Size comparison from 3298d54 to 978f773 Full report (24 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, psoc6, qpg, realtek, stm32)
|
|
PR #72622: Size comparison from 3298d54 to d91ad34 Increases above 0.2%:
Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
cecille
approved these changes
Jun 17, 2026
cecille
left a comment
cecille
left a comment
Contributor
There was a problem hiding this comment.
Gave an look, there wasn't anything surprising in here to me and it got the ambient sensing correction
@andreilitvin - this changes over the SDK to 1.6.1 are you OK with that or would you prefer to defer
@ReneJosefsen - would you mind taking a look here too? We'll regen at the ballot cut, just wanted to get this in for ambient sensing.
Contributor
|
Also @zaid-google - looks like the failure is related to groupcast, Would you mind taking a look? |
Contributor
It is fine from the SDK perspective, likely very desirable:
|
Contributor
|
@AryaHassanli - zaid is OOO, would you be able to fix the conformance problem? 1.6.1 introduces new groupcast requirements. |
Contributor
|
I checked Ambient Context Sensing Cluster xml changes and they seem to be OK. 1.6 to 1.6.1 changes
|
Contributor
Author
|
@tcarmelveilleux Could you please take a look at the latest commit and review the changes around groupcast? |
|
PR #72622: Size comparison from 3298d54 to d5e877d Increases above 0.2%:
Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
jmartinez-silabs
approved these changes
Jun 18, 2026
|
PR #72622: Size comparison from 3298d54 to 1046f0f Full report (5 builds for cc32xx, realtek, stm32)
|
|
PR #72622: Size comparison from 24e0342 to 0918523 Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
|
PR #72622: Size comparison from 24e0342 to 4f7e70b Full report (35 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
|
PR #72622: Size comparison from 24e0342 to 9c522c3 Increases above 0.2%:
Full report (22 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nrfconnect, psoc6, qpg, realtek, stm32)
|
|
PR #72622: Size comparison from 42e7a8f to bb49516 Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To review only the DM changes use this link
Related issues
Testing