Skip to content

examples/minimal-mdns: force chip_mdns="minimal"#72693

Merged
mergify[bot] merged 1 commit into
project-chip:masterfrom
ksperling-apple:mdns-example
Jun 23, 2026
Merged

examples/minimal-mdns: force chip_mdns="minimal"#72693
mergify[bot] merged 1 commit into
project-chip:masterfrom
ksperling-apple:mdns-example

Conversation

@ksperling-apple

Copy link
Copy Markdown
Contributor

Summary

The example uses the minimal mDNS library directly (mdns::Minimal::* and GlobalMinimalMdnsServer) and cannot build against the other backends. Pin chip_mdns="minimal" in args.gni so it builds on platforms (e.g. Darwin) where the default is "platform".

Testing

Now builds on Darwin without link errors.

The example uses the minimal mDNS library directly (mdns::Minimal::* and
GlobalMinimalMdnsServer) and cannot build against the other backends. Pin
chip_mdns="minimal" in args.gni so it builds on platforms (e.g. Darwin) where
the default is "platform".

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build configuration in examples/minimal-mdns/args.gni by explicitly setting the chip_mdns variable to "minimal". There are no review comments, and I have no additional feedback to provide on this change.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.74%. Comparing base (f6c81ca) to head (c91e632).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #72693   +/-   ##
=======================================
  Coverage   56.74%   56.74%           
=======================================
  Files        1630     1630           
  Lines      112290   112290           
  Branches    13114    13114           
=======================================
+ Hits        63719    63720    +1     
+ Misses      48571    48570    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

PR #72693: Size comparison from 10dc250 to c91e632

Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
platform target config section 10dc250 c91e632 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098620 1098620 0 0.0
RAM 133418 133418 0 0.0
bl702 lighting-app bl702+eth FLASH 1085172 1085172 0 0.0
RAM 109029 109029 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 882154 882154 0 0.0
RAM 108596 108596 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 777320 777320 0 0.0
RAM 103404 103404 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 790064 790064 0 0.0
RAM 108684 108684 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 739336 739336 0 0.0
RAM 97612 97612 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 719508 719508 0 0.0
RAM 97644 97644 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 569614 569614 0 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 597166 597166 0 0.0
RAM 205272 205272 0 0.0
efr32 lighting-app BRD4187C FLASH 1094860 1094860 0 0.0
RAM 135256 135256 0 0.0
lock-app BRD4187C FLASH 994784 994784 0 0.0
RAM 131292 131292 0 0.0
BRD4338a FLASH 799729 799729 0 0.0
RAM 243432 243432 0 0.0
esp32 all-clusters-app c3devkit DRAM 99884 99884 0 0.0
FLASH 1626632 1626632 0 0.0
IRAM 94776 94776 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 842952 842952 0 0.0
RAM 157755 157755 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1749076 1749076 0 0.0
RAM 215476 215476 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1626468 1626468 0 0.0
RAM 211604 211604 0 0.0
light cy8ckit_062s2_43012 FLASH 1470780 1470780 0 0.0
RAM 197436 197436 0 0.0
lock cy8ckit_062s2_43012 FLASH 1504228 1504228 0 0.0
RAM 225268 225268 0 0.0
qpg lighting-app qpg6200+debug FLASH 843044 843044 0 0.0
RAM 127908 127908 0 0.0
lock-app qpg6200+debug FLASH 782928 782928 0 0.0
RAM 118840 118840 0 0.0
realtek light-switch-app rtl8777g FLASH 689304 689304 0 0.0
RAM 101780 101780 0 0.0
lighting-app rtl8777g FLASH 730248 730248 0 0.0
RAM 102052 102052 0 0.0
stm32 light STM32WB5MM-DK FLASH 478936 478936 0 0.0
RAM 141492 141492 0 0.0
telink all-devices-app tl7218x FLASH 845030 845030 0 0.0
RAM 99092 99092 0 0.0
tlsr9118bdk40d FLASH 636404 636404 0 0.0
RAM 120224 120224 0 0.0
bridge-app tl7218x FLASH 734066 734066 0 0.0
RAM 97700 97700 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 800596 800596 0 0.0
RAM 42380 42380 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl7218x FLASH 845736 845736 0 0.0
RAM 101492 101492 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 734556 734556 0 0.0
RAM 57816 57816 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 795618 795618 0 0.0
RAM 75176 75176 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 734472 734472 0 0.0
RAM 34472 34472 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 615128 615128 0 0.0
RAM 118508 118508 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 841684 841688 4 0.0
RAM 97376 97376 0 0.0

@andy31415 andy31415 added the sdk-maintainer-approved PR marked by `matter-sdk-maintainers` as suitable for MERGE - meets guideline & sufficient reviews. label Jun 23, 2026
@mergify mergify Bot merged commit 693625b into project-chip:master Jun 23, 2026
79 checks passed
@ksperling-apple ksperling-apple deleted the mdns-example branch June 23, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples review - pending sdk-maintainer-approved PR marked by `matter-sdk-maintainers` as suitable for MERGE - meets guideline & sufficient reviews.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants