examples/minimal-mdns: force chip_mdns="minimal"#72693
Merged
Merged
Conversation
The example uses the minimal mDNS library directly (mdns::Minimal::* and GlobalMinimalMdnsServer) and cannot build against the other backends. Pin chip_mdns="minimal" in args.gni so it builds on platforms (e.g. Darwin) where the default is "platform".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72693 +/- ##
=======================================
Coverage 56.74% 56.74%
=======================================
Files 1630 1630
Lines 112290 112290
Branches 13114 13114
=======================================
+ Hits 63719 63720 +1
+ Misses 48571 48570 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
PR #72693: Size comparison from 10dc250 to c91e632 Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The example uses the minimal mDNS library directly (mdns::Minimal::* and GlobalMinimalMdnsServer) and cannot build against the other backends. Pin chip_mdns="minimal" in args.gni so it builds on platforms (e.g. Darwin) where the default is "platform".
Testing
Now builds on Darwin without link errors.