[ci] Add MG26 LLVM Bluetooth library in EFR32 Docker - #74043
[ci] Add MG26 LLVM Bluetooth library in EFR32 Docker#74043malbert-silabs wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Docker build version was advanced to record MG26 LLVM Bluetooth library support. The EFR32 Simplicity SDK keep-list now retains Suggested reviewers: Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The EFR32 build image now retains the MG26 LLVM Bluetooth link-layer archive, enabling the intended builds without an identified deployment or runtime risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, consistent addition to the SDK keep-list plus a standard version bump, with no apparent format or integration issues.
Pull request overview
This PR updates the EFR32 build Docker image inputs so the Simplicity SDK content needed to build EFR32MG26 targets with LLVM (specifically the Bluetooth link-layer static library) is retained in the image.
Changes:
- Keep the MG26 (xg26) LLVM Bluetooth LE controller
liblinklayer.ain the Simplicity SDK keep-list used by the EFR32 Docker image build. - Bump the base
chip-buildDocker version stamp to trigger rebuild/publication.
File summaries
| File | Description |
|---|---|
| integrations/docker/images/stage-2/chip-build-efr32/files-slt/simplicity_sdk_keep_folders.txt | Adds the missing bluetooth_le_controller/build/llvm/xg26/release/liblinklayer.a entry so it’s preserved in the EFR32 image. |
| integrations/docker/images/base/chip-build/version | Increments the Docker build version to roll a new image containing the updated SDK keep-list. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #74043 +/- ##
=======================================
Coverage 57.42% 57.42%
=======================================
Files 1940 1940
Lines 127712 127712
Branches 14502 14502
=======================================
Hits 73338 73338
Misses 54374 54374 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
A Bluetooth library was missing to be able to build MG26 with LLVM. This PR adds that lib to the
simplicity_sdk_keep_folders.txtso it will be available within the Docker image.Related issues
N/A
Testing
Confirmed locally this is the required change.
Docker CI should fail if this change breaks something.