Skip to content

[ci] Add MG26 LLVM Bluetooth library in EFR32 Docker - #74043

Open
malbert-silabs wants to merge 1 commit into
project-chip:masterfrom
malbert-silabs:docker-mg26-lib
Open

[ci] Add MG26 LLVM Bluetooth library in EFR32 Docker#74043
malbert-silabs wants to merge 1 commit into
project-chip:masterfrom
malbert-silabs:docker-mg26-lib

Conversation

@malbert-silabs

Copy link
Copy Markdown
Contributor

Summary

A Bluetooth library was missing to be able to build MG26 with LLVM. This PR adds that lib to the simplicity_sdk_keep_folders.txt so it will be available within the Docker image.

Related issues

N/A

Testing

Confirmed locally this is the required change.
Docker CI should fail if this change breaks something.

Copilot AI lite review requested due to automatic review settings September 9, 2026 19:55
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0f9c7354-357d-4562-bdbc-941702f42c13

📥 Commits

Reviewing files that changed from the base of the PR and between dade3ed and 5fefe00.

📒 Files selected for processing (2)
  • integrations/docker/images/base/chip-build/version
  • integrations/docker/images/stage-2/chip-build-efr32/files-slt/simplicity_sdk_keep_folders.txt

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The Docker build version was advanced to record MG26 LLVM Bluetooth library support. The EFR32 Simplicity SDK keep-list now retains bluetooth_le_controller/build/llvm/xg26/release/liblinklayer.a.

Suggested reviewers: lpbeliveau

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 5fefe

The EFR32 build image now retains the MG26 LLVM Bluetooth link-layer archive, enabling the intended builds without an identified deployment or runtime risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding the MG26 LLVM Bluetooth library to the EFR32 Docker image.
Description check ✅ Passed The description accurately explains the missing library, the keep-list update, the MG26 LLVM build purpose, and the testing performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a minimal, consistent addition to the SDK keep-list plus a standard version bump, with no apparent format or integration issues.

Pull request overview

This PR updates the EFR32 build Docker image inputs so the Simplicity SDK content needed to build EFR32MG26 targets with LLVM (specifically the Bluetooth link-layer static library) is retained in the image.

Changes:

  • Keep the MG26 (xg26) LLVM Bluetooth LE controller liblinklayer.a in the Simplicity SDK keep-list used by the EFR32 Docker image build.
  • Bump the base chip-build Docker version stamp to trigger rebuild/publication.
File summaries
File Description
integrations/docker/images/stage-2/chip-build-efr32/files-slt/simplicity_sdk_keep_folders.txt Adds the missing bluetooth_le_controller/build/llvm/xg26/release/liblinklayer.a entry so it’s preserved in the EFR32 image.
integrations/docker/images/base/chip-build/version Increments the Docker build version to roll a new image containing the updated SDK keep-list.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.42%. Comparing base (dade3ed) to head (5fefe00).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #74043   +/-   ##
=======================================
  Coverage   57.42%   57.42%           
=======================================
  Files        1940     1940           
  Lines      127712   127712           
  Branches    14502    14502           
=======================================
  Hits        73338    73338           
  Misses      54374    54374           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants