Merge TC_SU_2_7 into TC_SU_2_2 for single run and update. - #74067
Draft
jtrejoespinoza-grid wants to merge 9 commits into
Draft
Merge TC_SU_2_7 into TC_SU_2_2 for single run and update.#74067jtrejoespinoza-grid wants to merge 9 commits into
jtrejoespinoza-grid wants to merge 9 commits into
Conversation
…SU_2_2 transition waiting for 180s busy after kDelayedonQuery
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #74067 +/- ##
==========================================
- Coverage 57.55% 56.81% -0.74%
==========================================
Files 1921 2002 +81
Lines 125332 130443 +5111
Branches 14158 15188 +1030
==========================================
+ Hits 72134 74114 +1980
- Misses 53198 56329 +3131 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the changes to merge the TestCase TC_SU_2_7.py into TC_SU_2_2. py
New step order:
Implement this new step sequence in
TC_SU_2_2.py(replacing its current 0-6 steps and folding in 2.7's steps). For each step, wire up both the attribute-based verification already in TC_SU_2_2 (where applicable) and the StateTransition/other event verification from TC_SU_2_7, usingEventSubscriptionHandleralongside the existingAttributeSubscriptionHandlerpattern already used in the file (see Step 4's dual-track pattern as precedent).kDelayByProvider(from 2.7 step 2).DownloadErrorevent with SoftwareVersion matching, BytesDownloaded>0, ProgressPercent>0, PlatformCode=NULL.kFailure(from 2.7 step 3).BasicInformation.LocalConfigDisabledis supported, write it to False viaattribute_guard/write_single_attribute(from 2.7 step 4).--userConsentNeeded+ app pipes, from 2.7 step 5).--applyUpdateAction awaitNextAction --delayedApplyActionTimeSec N) → after asserting DelayedOnApply, restart/reconfigure the provider to permit Proceed so the DUT's scheduled retry completes the apply → DUT reboots on V2.kDelayByProvider(2.7 step 7).VersionAppliedevent with correct SoftwareVersion and non-null ProductID (2.7 step 1). Existing 2.2 basic-information version check after reboot.This order consider the old version of 2.7: Not single ota update order (https://github.com/jtrejoespinoza-grid/connectedhomeip/blob/a50d879769df0c0fd984a3545954438ba025813a/src/python_testing/TC_SU_2_7.py)
Related issues
Fixes: project-chip/matter-test-scripts#804
Testing
Add the new test steps as sequence.
Update the numbers of the test steps.
Add missing steps between actions
Update log statements that mentions test step.
Run the test locally: