Matter Shell WebSocket #1990
Open
Matter Shell WebSocket #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of terminal I/O. Incudes a bare-bones webserver to make interaction more convenient
pullapprove
bot
requested review from
Apollon77,
lauckhart,
turon,
vves and
woody-apple
Apollon77
reviewed
May 6, 2025
…d description of the capability in the README
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (matches && matches[4] == 6) styleButton(matches[1], matches[3], matches[6]); | ||
|
|
||
| matches = message.match(/Attribute value for onOff (\d+)\/(\d+)\/(\d+)\/(\w+): (.+)/); // from "read attribute onOff" | ||
| if (matches) styleButton(matches[1], matches[2], matches[5]) |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
| function updateTile(nodeId, status) { | ||
| let tile = document.getElementById(`tile-${nodeId}`); | ||
| if (!tile) { | ||
| container = document.createElement('div'); |
Check warning
Code scanning / CodeQL
Missing variable declaration Warning
Comment on lines
+322
to
+323
| tile.innerHTML = "<small>Node " + nodeId + "<br><span class=" + | ||
| ((status === "connected") ? "connected-node-status>" : "connecting-node-status>") + status + "</span></small>"; |
Check failure
Code scanning / CodeQL
Client-side cross-site scripting High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ability for Matter Shell to optionally utilize a WebSock instead of terminal I/O. Incudes a bare-bones web server to make interaction more convenient although using a full-featured web server is recommended. I have an html/javascript controller that utilizes this capability, but it is not included in this PR