Do not use NotBefore=0 in certs validity periods#458
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces configurable certificate validity periods for the commissioner module, replacing hardcoded values with a new Validity parameter in FabricCredentials and NocGenerator. It also defines a DEFAULT_VALIDITY constant designed to avoid collisions with CHIP's epoch-0 sentinel. The review feedback highlights that while the API is now public, the Validity struct fields remain pub(crate), preventing external users from creating custom validity periods. Additionally, there is a suggestion to consolidate the Validity type and its default constant to reduce API fragmentation.
ivmarkov
force-pushed
the
validity-periods
branch
from
b626f0e to
13b9963
Compare
2 tasks
|
PR #458: Size comparison from 6c53af6 to 44e62ab Full report (8 builds for (core), dimmable-light, onoff-light, onoff-light-bt, speaker)
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #454 except with all Gemini code review comments addressed (and future comments to be addressed too).