Skip to content

fix: substraction issue in transport #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skoky wants to merge 2 commits into from
+1 −1
Closed

fix: substraction issue in transport #460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c733487
fix: substraction issue in transport
skoky May 23, 2026
f3d3261
Update rs-matter/src/transport/dedup.rs
skoky May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rs-matter/src/transport/dedup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ impl RxCtrState {
/// The method will return `false` if the message is detected to be duplicate, and therefore,
/// the RX state had not been updated.
pub fn post_recv(&mut self, msg_ctr: u32, is_encrypted: bool) -> bool {
let idiff = (msg_ctr as i32) - (self.max_ctr as i32);
let idiff = msg_ctr.wrapping_sub(self.max_ctr) as i32;
let udiff = idiff.unsigned_abs();

Comment thread
ivmarkov marked this conversation as resolved.
if msg_ctr == self.max_ctr {
Expand Down
Loading