Color Control#473
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'light_tests' example binary that exercises the 'OnOff', 'LevelControl', and 'ColorControl' clusters, along with its corresponding PICS configuration. It also defines the 'DEV_TYPE_EXTENDED_COLOR_LIGHT' device type and updates the integration test suite to run these new tests instead of the older 'dimmable_light' tests. Feedback on the changes highlights a potential panic in 'OnOffDeviceLogic::new' when reading the persistent state file if it is empty or corrupted, suggesting a more robust error handling approach instead of using '.unwrap()'.
|
PR #473: Size comparison from 1236da8 to 390e1bc Full report (8 builds for (core), dimmable-light, onoff-light, onoff-light-bt, speaker)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... similar to Level Control and On-Off.
And quite complex!
With this, we should have a complete story for lights, where only a minimal effort is required by the implementors / integrators - implementing the Hooks traits.
Still a few open topics to be solved later: