Bug/update gen templates json file for nested files/zapp 1297#1577
Merged
brdandu merged 1 commit intoApr 23, 2025
Conversation
Collaborator
Author
|
Tests already covered in zcl-loader.test.js |
brdandu
force-pushed
the
bug/updateGenTemplatesJsonFileForNestedFiles/ZAPP-1297
branch
2 times, most recently
from
807af61 to
24e77ba
Compare
paulr34
approved these changes
Apr 22, 2025
…on files within it are updated. The newly added templates json file is in sync and the older ones will be out of sync in the package table when a nested json file is changed - Removing the zcl extensions check because that is now covered by the newly added code. Not adding further tests for this because it is already covered in zcl-loader.test.js. See: test changing the zcl extension file in a top level templates json file and make sure it is re-loaded again - JIRA: ZAPP-1297
brdandu
force-pushed
the
bug/updateGenTemplatesJsonFileForNestedFiles/ZAPP-1297
branch
from
24e77ba to
38a2fe3
Compare
tecimovic
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When json files referenced from within the templates.json file are updated then checksum is calculated for those as well and updated accordingly.