Fix endianness issue when the hex value length is odd#1579
Merged
brdandu merged 2 commits intoApr 22, 2025
Merged
Conversation
Collaborator
brdandu
commented
Apr 21, 2025
brdandu
commented
- See the unit test to understand the issue here where 1600 should not be 0x640 but 0x0640 for proper endian conversion
- Added unit tests
- JIRA: ZAPP-1610
- See the unit test to understand the issue here where 1600 should not be 0x640 but 0x0640 for proper endian conversion - Added unit tests - JIRA: ZAPP-1610
ethanzhouyc
approved these changes
Apr 22, 2025
paulr34
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.