Adding db constraints for enum items, struct items and bitmap fields#1581
Merged
dhchandw merged 1 commit intoApr 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds database constraints for enum, struct, and bitmap fields and fixes a related bug in the collection of ZCL data types from the properties file.
- Added a new block to handle ZCLDataTypes in collectDataFromPropertiesFile.
- Fixed a bug where an undefined variable (obj) was used when assigning ZCLDataTypes.
Files not reviewed (1)
- src-electron/db/zap-schema.sql: Language not supported
paulr34
approved these changes
Apr 23, 2025
- also fixing related bug
dhchandw
force-pushed
the
task/addDbConstraintsFields
branch
from
f086caf to
b57695a
Compare
brdandu
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #907