Fix Matter helpers to do the right thing with global enums/bitmaps.#1593
Merged
brdandu merged 1 commit intoMay 6, 2025
Merged
Conversation
bzbarsky-apple
requested review from
brdandu,
paulr34 and
tecimovic
as code owners
paulr34
approved these changes
May 5, 2025
brdandu
reviewed
May 5, 2025
Collaborator
brdandu
left a comment
brdandu
left a comment
There was a problem hiding this comment.
There is a regen check failure on the Matter SDK. Is that expected?
Contributor
Author
Yes. See PR description. |
brdandu
approved these changes
May 5, 2025
bzbarsky-apple
force-pushed
the
fix-matter-helpers-enum-bitmap
branch
from
57835d5 to
ff9d9be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: the Matter generation changes here are somewhat expected, because some of the new template changes in Matter are buggy until project-chip/connectedhomeip#38733 merges. There should be no compat impact here for Matter bits from older Matter releases.