show save button in ide when dirtyflag is sent to parent #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1594 +/- ##
==========================================
+ Coverage 66.93% 66.98% +0.05%
==========================================
Files 197 198 +1
Lines 21827 22228 +401
Branches 4817 4914 +97
==========================================
+ Hits 14609 14890 +281
- Misses 7218 7338 +120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ethanzhouyc
approved these changes
May 6, 2025
paulr34
force-pushed
the
fixSaveButton_IdeIntegration
branch
from
c2b7655 to
c475270
Compare
brdandu
reviewed
May 8, 2025
ethanzhouyc
reviewed
May 8, 2025
| @@ -61,9 +61,7 @@ | |||
| flat | |||
| no-caps | |||
| @click="saveChanges" | |||
| v-if=" | |||
| this.$store.state.zap.saveButtonVisible && this.$store.state.zap.isDirty | |||
| " | |||
There was a problem hiding this comment.
If saveButtonVisible and isDirty is not used in other places, after they are deleted, their related code to define or set their value should be removed too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.