-
Notifications
You must be signed in to change notification settings - Fork 90
Open first endpoint when opening .zap file #1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open first endpoint when opening .zap file #1673
Conversation
brdandu
commented
Nov 19, 2025
- When no endpoint is selected and there is an endpoint reference available then select that
- JIRA: ZAPP-1500
Summary of ChangesHello @brdandu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience when opening Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a change to automatically select the first endpoint when a .zap file is opened and no endpoint is currently selected. The implementation in ZclEndpointCard.vue achieves this by adding logic to the created lifecycle hook.
While the functionality is correct, I have a suggestion regarding the architecture. The logic for auto-selecting an endpoint would be better placed in the parent component that manages the list of all endpoints, rather than within the individual endpoint card component. This would improve separation of concerns and maintainability. Please see my detailed comment.
7885191 to
52ce53d
Compare
9da9026 to
bc88e62
Compare
- When no endpoint is selected and this.endpointIdListSorted is available then choose the first endpoint in it - JIRA: ZAPP-1500
bc88e62 to
692ed62
Compare