Bump AppWrapper version to 1.1.1 and Kueue to 0.11.0 #673
+353
−239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dgrove-oss
force-pushed
the
aw-1.1
branch
2 times, most recently
from
4155f44 to
79578c8
Compare
dgrove-oss
commented
Mar 21, 2025
| sigs.k8s.io/yaml v1.4.0 | ||
| ) | ||
|
|
||
| replace k8s.io/client-go => k8s.io/client-go v0.31.4 | ||
|
|
||
| replace k8s.io/api => k8s.io/api v0.31.4 |
There was a problem hiding this comment.
There are more replace directives here than I'd like, but it was expedient in the short term. Someone who has a better understanding of how to coordinate Kubernetes/OpenShift API versions may be able to do something less heavy handed.
dgrove-oss
force-pushed
the
aw-1.1
branch
2 times, most recently
from
7b2789f to
472df03
Compare
Decouple the Kueue version deployed on the cluster for CI testing from the golang dependency on Kueue APIs used in the e2e go test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should not be merged until we are ready to upgrade Kueue to 0.11.x.
This PR bumps the AppWrapper version to 1.1.1, which is built to work with Kueue 0.11.
The key change is that in Kueue 0.11, AppWrapper is a built-in integration. This enables the removal of all Kueue-specific code from the AppWrapper controller, which eliminates the tight coupling between AppWrapper and Kueue versions.