fix(RHOAIENG-20531): propagate annotations to ray pods

[chipspeak]

Issue link

RHOAIENG-20531

What changes have been made

Fix to propagate annotations passed in the cluster config to the Ray head and worker pods.

Verification steps

• Pass an annotation during cluster definition in a notebook.
• Check the CR on cluster and the annotation should be reflected there.

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.45%. Comparing base (e46ee4c) to head (11eb02d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files          24       24           
  Lines        1419     1419           
=======================================
  Hits         1312     1312           
  Misses        107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Bobbins228]

The code looks clean but the annotations config vars are added to tests that are not really necessary/are helper functions.

The create_cluster_all_config_params() test is a fine place to put them for testing purposes but you need to assert that the params are set properly in the test_config_creation_all_parameters Unit Test.

Outdated

[laurafitzgerald]

/approve
/lgtm

[laurafitzgerald]

/override kubernetes

[openshift-ci]

@laurafitzgerald: Overrode contexts on behalf of laurafitzgerald: kubernetes

In response to this:

/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kryanbeane]

/lgtm
/approve
/override kubernetes

[openshift-ci]

@kryanbeane: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• kubernetes

Only the following failed contexts/checkruns were expected:

• add-approve-lgtm-label
• tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/lgtm
/approve
/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kryanbeane]

/lgtm
/approve
/override kubernetes

[openshift-ci]

@kryanbeane: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• kubernetes

Only the following failed contexts/checkruns were expected:

• add-approve-lgtm-label
• tide
• verify-0_basic_ray
• verify-1_cluster_job_client
• verify-2_basic_interactive
• verify-3_widget_example
• verify-local_interactive
• verify-ray_job_client

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/lgtm
/approve
/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane, laurafitzgerald

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kryanbeane,laurafitzgerald]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kryanbeane]

/override kubernetes

[openshift-ci]

@kryanbeane: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• kubernetes

Only the following failed contexts/checkruns were expected:

• add-approve-lgtm-label
• tide
• verify-0_basic_ray
• verify-1_cluster_job_client
• verify-2_basic_interactive
• verify-3_widget_example
• verify-local_interactive
• verify-ray_job_client

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kryanbeane]

/override tide

[openshift-ci]

@kryanbeane: Overrode contexts on behalf of kryanbeane: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[laurafitzgerald]

/override kubernetes

[openshift-ci]

@laurafitzgerald: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• kubernetes

Only the following failed contexts/checkruns were expected:

• add-approve-lgtm-label
• tide
• verify-0_basic_ray
• verify-1_cluster_job_client
• verify-2_basic_interactive
• verify-3_widget_example
• verify-local_interactive
• verify-ray_job_client

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.