Skip to content

Update Ray to v2.44.1 and update Runtime Image refs #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025

Conversation

kryanbeane
Copy link
Contributor

@kryanbeane kryanbeane commented May 2, 2025

Issue link

RHOAIENG-24672

What changes have been made

Updated Ray version and runtime image sha. Also snuck in the ROCm docs update from an older commit.

Verification steps

Check https://quay.io/repository/modh/ray?tab=tags&tag=latest and verify that the SHA added in this PR corresponds to the correct image

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.41%. Comparing base (f45e021) to head (e0d9acb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #825   +/-   ##
=======================================
  Coverage   92.40%   92.41%           
=======================================
  Files          23       24    +1     
  Lines        1396     1397    +1     
=======================================
+ Hits         1290     1291    +1     
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@szaher szaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency should we retire test/things related to python 3.9?

@kryanbeane kryanbeane force-pushed the ray-2.44.1 branch 2 times, most recently from 2222b36 to 26454e6 Compare May 6, 2025 07:43
@kryanbeane
Copy link
Contributor Author

for consistency should we retire test/things related to python 3.9?

retired python 3.9

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
Copy link
Contributor

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chipspeak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2025
@kryanbeane kryanbeane requested a review from szaher May 7, 2025 09:23
@chipspeak
Copy link
Contributor

I think we can just merge this today once the conflict is resolved. Thanks again, @kryanbeane !

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2025
@project-codeflare project-codeflare deleted a comment from openshift-ci bot May 12, 2025
@chipspeak
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
@kryanbeane
Copy link
Contributor Author

/override kubernetes

Copy link
Contributor

openshift-ci bot commented May 12, 2025

@kryanbeane: Overrode contexts on behalf of kryanbeane: kubernetes

In response to this:

/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chipspeak chipspeak merged commit 82fa656 into project-codeflare:main May 13, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants