rpm: fix systemd scriptlet failures in Anaconda/Kickstart installs#1020
Open
cpuguy83 wants to merge 1 commit intoproject-dalec:mainfrom
Open
rpm: fix systemd scriptlet failures in Anaconda/Kickstart installs#1020cpuguy83 wants to merge 1 commit intoproject-dalec:mainfrom
cpuguy83 wants to merge 1 commit intoproject-dalec:mainfrom
Conversation
RPM %post and %preun scriptlets used raw systemctl commands that exit non-zero when systemd is installed but not running, causing Anaconda to abort package installation (libdnf5 treats scriptlet errors as fatal). %post: Replace raw 'systemctl enable [--now]' with 'systemctl enable || :' gated on $1 == 1. For Start: true, use a separate 'systemctl start || :' guarded by /run/systemd/system. We intentionally avoid %systemd_post because it calls 'systemctl preset' which defers to system preset policy and would break the Enable: true contract. %preun: Replace raw 'systemctl disable --now' with %systemd_preun macro, which handles the $1 == 0 check and /run/systemd/system guard internally. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the RPM spec template’s systemd scriptlets to avoid fatal failures during installs in environments where systemd is installed but not running (e.g., Anaconda/Kickstart chroots), aligning with issue #1017.
Changes:
- Switch
%preunhandling from rawsystemctl disable --nowto%systemd_preun. - Adjust
%posthandling to usesystemctl enable ... || :(install-only) and, whenStart: true, a guardedsystemctl start ... || :. - Update RPM template unit tests to match the new scriptlet output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packaging/linux/rpm/template.go | Reworks systemd %post/%preun scriptlet generation to be non-fatal when systemd isn’t running and to use macros where appropriate. |
| packaging/linux/rpm/template_test.go | Updates expected rendered spec output for systemd scriptlets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPM
%postand%preunscriptlets used raw systemctl commands that exit non-zero when systemd is installed but not running, causing Anaconda to abort package installation (libdnf5 treats scriptlet errors as fatal).%post: Replace raw 'systemctl enable [--now]' with 'systemctl enable || :' gated on $1 == 1. For Start: true, use a separatesystemctl start || :guarded by/run/systemd/system. We intentionally avoid%systemd_postbecause it callssystemctl presetwhich defers to system preset policy and would break theEnable: truecontract.%preun: Replace rawsystemctl disable --nowwith%systemd_preunmacro, which handles the$1 == 0check and/run/systemd/systemguard internally.Fixes: #1017