Merged
Conversation
cpuguy83
force-pushed
the
struct_tag_linter
branch
2 times, most recently
from
5bc5217 to
6e9f77a
Compare
adamperlin
suggested changes
Mar 3, 2025
cpuguy83
force-pushed
the
struct_tag_linter
branch
from
6e9f77a to
f9d506f
Compare
This makes sure yaml and jsons truct tags stay in sync. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
struct_tag_linter
branch
from
f9d506f to
0d8b710
Compare
adamperlin
approved these changes
Mar 3, 2025
Contributor
adamperlin
left a comment
adamperlin
left a comment
There was a problem hiding this comment.
Looks good to me pending the unrelated CI failures!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example (this is from a commit I added temporarily: 5bc5217).