Draft
Conversation
Introduce SubPackage and SubPackageDependencies types for supplemental package support (subpackages from shared builds). Add Packages field to Target, validation in Spec.Validate(), and full unit test coverage. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Add SubPackages() method and supporting types to produce %package, %description, %files, and scriptlet sections for each supplemental package. Refactor Install() to include subpackage artifacts in the shared %install section. Includes comprehensive template-level tests. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Test RPMSpec() at the LLB layer by marshaling the returned state, extracting protobuf ops, and asserting on Mkdir/Mkfile actions. Covers default and custom directory paths, subpackage sections with default and custom names, dependencies, sorted ordering, install artifacts, wrong-target exclusion, and invalid spec error handling. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Add subpackage support to the Debian packaging pipeline: - Control file: emit additional Package: stanzas for each subpackage with Architecture, Section, Depends, Recommends, Replaces, Conflicts, Provides, and Description fields. - Install scripts: refactor createInstallScripts into per-package helper (packageInstallScripts) that generates .install, .manpages, .dirs, .docs, and .links files for both the primary package and subpackages. - Postinst: refactor ownership/capabilities helpers to accept artifacts directly; add generateSubPackagePostinst for per-subpackage postinst. - Fix perms: refactor fixupArtifactPerms to iterate primary + subpackages via writePackagePerms; update OverridePerms to check subpackage artifacts. - Systemd: extend OverrideSystemd to emit dh_installsystemd -p<pkgName> for subpackage units; refactor customDHInstallSystemdPostinst to handle both primary and subpackage units via writeCustomEnableForUnits helper. - Add comprehensive LLB-level and unit tests covering all generated files. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #607