Skip to content

Conversation

@bacciotti
Copy link
Contributor

@bacciotti bacciotti commented Jul 24, 2025

Summary by Sourcery

Remove in-script PR label validation and defer all label checks to Tekton, simplifying deploy logic across both deploy scripts.

Enhancements:

  • Remove manual PR label checks for Jenkins tests, skipping smokes, and missing smoke-tests labels in deploy scripts
  • Unify handling of missing PR number or labels to assume scheduled/manual runs with consistent info messages
  • Add a generic info message indicating that label validation is now performed by Tekton

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 24, 2025

Reviewer's Guide

This PR removes manual label-based decision logic from deployment scripts, centralizes label validation in Tekton, and streamlines PR number/label absence handling with updated logging.

Flow diagram for updated deployment label validation process

flowchart TD
    A[Start Deployment Script] --> B{PR Number or Labels Present?}
    B -- No --> C[Log: Scheduled or Manual Test Run]
    C --> D[Log: Proceeding with Full Smoke Tests]
    D --> E[Log: Starting deploy. Label validation was already handled by Tekton.]
    B -- Yes --> E
    E --> F[Continue Deployment]
Loading

File-Level Changes

Change Details Files
Removed manual PR label checks and snapshot component usage
  • Deleted snapshot_components calculation in deploy.py
  • Removed run-jenkins-tests, ok-to-skip-smokes, and smokes-required checks in both scripts
files/bin/deploy.py
files/bin/deploy-iqe-cji.py
Simplified handling when PR number or labels are absent
  • Inverted check to if not pr_number and unified full smoke tests path in deploy.py
  • Replaced empty-labels branch with if not self.pr_labels in deploy-iqe-cji.py
files/bin/deploy.py
files/bin/deploy-iqe-cji.py
Added informational logging for Tekton-based validation
  • Inserted display message noting label validation is handled by Tekton in deploy.py
  • Inserted same Tekton validation log in deploy-iqe-cji.py
files/bin/deploy.py
files/bin/deploy-iqe-cji.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bacciotti - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@bacciotti bacciotti closed this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants