Skip to content

Conversation

@bacciotti
Copy link
Contributor

@bacciotti bacciotti commented Jul 24, 2025

Summary by Sourcery

Revert recent label-handling changes and restore the repository to commit d032050 by removing Jenkins test flags, required smoke-test checks, and unused snapshot component logic from the deploy scripts

Chores:

  • Revert PR label branches for Jenkins tests and smoke-test enforcement in deploy-iqe-cji.py
  • Simplify label handling and info messaging for manual or scheduled runs in deploy-iqe-cji.py
  • Remove snapshot_components calculation and related smoke-test checks from deploy.py

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 24, 2025

Reviewer's Guide

This PR restores deploy scripts to the state of commit d032050 by removing custom PR label branches (Jenkins tests and smoke validations), consolidating label handling under Tekton, and unifying log messages.

Sequence diagram for simplified label handling in deploy scripts

sequenceDiagram
    participant User
    participant DeployScript
    participant Tekton
    User ->> DeployScript: Trigger deploy (with or without PR labels)
    DeployScript ->> DeployScript: Check if pr_labels/labels is empty
    alt No labels
        DeployScript ->> DeployScript: Log scheduled/manual run, proceed with full smoke tests
    else "ok-to-skip-smokes" label present
        DeployScript ->> DeployScript: Log skip message, exit
    else
        DeployScript ->> DeployScript: Proceed with deploy (label validation handled by Tekton)
    end
    DeployScript ->> Tekton: Delegate label validation
    Tekton -->> DeployScript: Validation result
    DeployScript ->> DeployScript: Continue deploy or exit based on validation
Loading

Class diagram for label handling logic in deploy scripts

classDiagram
    class DeployIQECJI {
        +pr_labels
        +run()
        +check_cji_jobs()
    }
    class Deploy {
        +labels
        +main()
    }
    DeployIQECJI : - Removed custom label branches ("run-jenkins-tests", "smokes-required")
    DeployIQECJI : + Now only checks for "ok-to-skip-smokes" and empty labels
    Deploy : - Removed custom label branches ("run-jenkins-tests", "smokes-required")
    Deploy : + Now only checks for "ok-to-skip-smokes" and empty labels
    DeployIQECJI --> Deploy : Similar label handling logic
Loading

File-Level Changes

Change Details Files
Simplify PR label handling in deploy-iqe-cji.py
  • Removed branches for 'run-jenkins-tests' and 'smokes-required' labels
  • Inverted empty-label check to early display and proceed
  • Added uniform '[INFO]' logging and delegated label validation to Tekton
  • Retained only 'ok-to-skip-smokes' check before pod execution
files/bin/deploy-iqe-cji.py
Simplify PR label handling in deploy.py
  • Removed 'run-jenkins-tests' branch and snapshot_components usage
  • Discarded Koku-specific smoke-test validation
  • Standardized '[INFO]' logging for manual or PR runs
  • Kept only 'ok-to-skip-smokes' early return
files/bin/deploy.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bacciotti bacciotti enabled auto-merge (squash) July 24, 2025 15:40
@bacciotti bacciotti merged commit 095ab5e into main Jul 24, 2025
1 check passed
@bacciotti bacciotti deleted the restore-ci-changes branch July 24, 2025 15:40
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bacciotti - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants