Restoring changes.

[bacciotti]

Summary by Sourcery

Add consistent PR label handling across deploy scripts to control test runs, enforce smoke-test labeling, and improve logging for non-PR executions.

Enhancements:

• Add "run-jenkins-tests" label check to skip Konflux deploys and run Jenkins tests instead
• Add "ok-to-skip-smokes" label check to skip smoke tests in both deploy-iqe-cji.py and deploy.py
• Enforce the presence of smoke-tests labels when "smokes-required" is set, exiting early if missing
• Treat missing PR labels or PR number scenario as a nightly/manual test run with updated informational messages

[sourcery-ai]

Reviewer's Guide

Refactor deployment scripts to centralize and enhance PR label-driven test skipping and enforcement logic across both deploy-iqe-cji.py and deploy.py implementations.

Class diagram for main deployment logic changes

classDiagram
    class DeployIQECJI {
        +pr_labels
        +run()
        +check_cji_jobs()
    }
    class Deploy {
        +labels
        +main()
    }
    DeployIQECJI : +run() updated to centralize label logic
    Deploy : +main() updated to centralize label logic

Loading

Flow diagram for PR label-driven test skipping and enforcement logic

flowchart TD
    A[Start] --> B{Are PR labels present?}
    B -- No --> C[Assume scheduled/manual run]
    C --> D[Proceed with full smoke tests]
    B -- Yes --> E{Label: run-jenkins-tests?}
    E -- Yes --> F[Display: Run Jenkins tests instead of Konflux]
    F --> Z[End]
    E -- No --> G{Label: ok-to-skip-smokes?}
    G -- Yes --> H[Display: Skip smoke tests]
    H --> Z
    G -- No --> I{Label: smokes-required AND missing *smoke-tests label?}
    I -- Yes --> J[Exit: Missing smoke tests labels]
    I -- No --> K[Proceed with deploy/run]
    K --> Z[End]

Loading

File-Level Changes

Change	Details	Files
Restructure PR label handling in deploy-iqe-cji.py to prioritize test selection	Added top-level checks for 'run-jenkins-tests', 'ok-to-skip-smokes', and 'smokes-required' labels Reorganized if-else to distinguish between labeled vs unlabeled runs Removed previous redundant 'ok-to-skip-smokes' branch	files/bin/deploy-iqe-cji.py
Introduce snapshot_components and mirror label-driven logic in deploy.py with koku-specific smoke test enforcement	Initialized snapshot_components from snapshot.components Added checks for 'run-jenkins-tests', 'ok-to-skip-smokes', and conditional exit if koku lacks smoke-test labels Updated log messages for clarity on manual/nightly runs	files/bin/deploy.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @bacciotti - I've reviewed your changes - here's some feedback:

• There’s duplicate label‐handling logic in both deploy‐iqe‐cji.py and deploy.py—consider extracting it into a shared utility function to keep behavior in sync and reduce duplicated code.
• Logging messages vary in style (some use “[INFO]” prefixes and some don’t); it’d be cleaner to standardize on a single format or switch to a proper logging framework.
• The smoke-tests label validation (the endswith check) could be encapsulated in its own function or config lookup so adding new test labels later is less error-prone.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- There’s duplicate label‐handling logic in both deploy‐iqe‐cji.py and deploy.py—consider extracting it into a shared utility function to keep behavior in sync and reduce duplicated code.
- Logging messages vary in style (some use “[INFO]” prefixes and some don’t); it’d be cleaner to standardize on a single format or switch to a proper logging framework.
- The smoke-tests label validation (the endswith check) could be encapsulated in its own function or config lookup so adding new test labels later is less error-prone.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}