use APP_BUILD_DIR instead of OUTPUT_DIR

[rawagner]

requires RedHatInsights/insights-frontend-builder-common#278

Summary by Sourcery

CI:

• Replace OUTPUT_DIR build argument with APP_BUILD_DIR in Tekton pipelines for koku-ui-hccm and koku-ui-ros.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update Tekton pipeline configurations to use APP_BUILD_DIR instead of OUTPUT_DIR for build arguments, aligning with the updated insights-frontend-builder-common convention.

File-Level Changes

Change	Details	Files
Replace OUTPUT_DIR with APP_BUILD_DIR build argument in pipelines	Swap default build-arg in koku-ui-hccm pull request pipeline Swap default build-arg in koku-ui-hccm push pipeline Swap default build-arg in koku-ui-ros pull request pipeline Swap default build-arg in koku-ui-ros push pipeline	.tekton/koku-ui-hccm-pull-request.yaml .tekton/koku-ui-hccm-push.yaml .tekton/koku-ui-ros-pull-request.yaml .tekton/koku-ui-ros-push.yaml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @rawagner, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the naming convention for a build output directory variable within Tekton pipeline configurations. By replacing OUTPUT_DIR with APP_BUILD_DIR, it aligns these pipeline definitions with a broader change in a common builder component, improving consistency and maintainability across related frontend applications.

Highlights

• Variable Renaming: The OUTPUT_DIR build argument has been consistently renamed to APP_BUILD_DIR across multiple Tekton pipeline configuration files.
• Tekton Pipeline Updates: This change affects both pull request and push pipeline definitions for koku-ui-hccm and koku-ui-ros applications, ensuring standardized build argument usage.
• Dependency: This pull request is dependent on a related change in the insights-frontend-builder-common repository, specifically PR #278, which likely introduces or formalizes the APP_BUILD_DIR variable.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request updates the build argument in Tekton pipeline configurations from OUTPUT_DIR to APP_BUILD_DIR. The change is applied consistently across four YAML files for koku-ui-hccm and koku-ui-ros applications. This change is in response to an update in the common builder dependency, as noted in the description. The modifications are correct and align with the stated purpose of the pull request. I have no further suggestions.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.82%. Comparing base (a7ffd0c) to head (5cda459).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4602   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files         480      480           
  Lines        9075     9075           
  Branches     2198     2197    -1     
=======================================
  Hits         8061     8061           
  Misses        954      954           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dlabrecq]

Thanks for the update. I already updated APP_BUILD_DIR via this PR #4601, so we can close this one.