Clean up release-all based on PR review #4645
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactored the release-all script to replace nested appEnv/clouddotEnv checks with boolean flags and flat, targeted assignments for HCCM and ROS stage/prod arguments. Flow diagram for refactored environment argument assignment in release-all scriptflowchart TD
A["User selects appEnv and clouddotEnv"] --> B["Set DEBUG env variable"]
B --> C["isHccm = appEnv is 'koku-ui-hccm' or 'all'"]
B --> D["isRos = appEnv is 'koku-ui-ros' or 'all'"]
B --> E["isStage = clouddotEnv is 'stage' or 'all'"]
B --> F["isProd = clouddotEnv is 'prod' or 'all'"]
C --> G["If isHccm and isStage, set HCCM_STAGE_ARG = '-s'"]
C --> H["If isHccm and isProd, set HCCM_PROD_ARG = '-p'"]
D --> I["If isRos and isStage, set ROS_STAGE_ARG = '-q'"]
D --> J["If isRos and isProd, set ROS_PROD_ARG = '-r'"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @dlabrecq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the clarity and structure of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider refactoring the repeated if blocks by using a data-driven mapping (e.g. { HCCM: {stage: '-s', prod: '-p'}, ROS: {stage: '-q', prod: '-r'} }) and iterating through it to reduce duplication and improve maintainability.
- Add explicit validation or a default case for unexpected appEnv or clouddotEnv values to avoid silently skipping flag assignments.
- Before setting new vars, you may want to clear any existing HCCM_ARG and ROS_ARG values so you don’t carry over stale flags between runs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider refactoring the repeated if blocks by using a data-driven mapping (e.g. { HCCM: {stage: '-s', prod: '-p'}, ROS: {stage: '-q', prod: '-r'} }) and iterating through it to reduce duplication and improve maintainability.
- Add explicit validation or a default case for unexpected appEnv or clouddotEnv values to avoid silently skipping flag assignments.
- Before setting new vars, you may want to clear any existing HCCM_*_ARG and ROS_*_ARG values so you don’t carry over stale flags between runs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the logic for setting environment variables in the release-all.js script, making it much cleaner and easier to understand by removing nested conditional statements. The change is a significant improvement. I've added one suggestion to further improve maintainability by using a data-driven approach, which would reduce code duplication and make future changes simpler.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4645 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 480 480
Lines 9075 9075
Branches 2197 2198 +1
=======================================
Hits 8061 8061
- Misses 953 954 +1
+ Partials 61 60 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Clean up release-all script based on PR review
Summary by Sourcery
Enhancements: