-
Notifications
You must be signed in to change notification settings - Fork 48
Replace branch with pkg name #4677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refactors the UI version component to use the package name (from package.json) instead of the Git branch for version identification, updating environment variable definitions in Webpack configs and removing the appName prop across application entry points. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @dlabrecq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the way UI version information is generated and displayed across the applications. It introduces a more robust and consistent approach by leveraging standardized environment variables for the package name and commit hash, centralizing the logic within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully refactors the UI versioning mechanism by replacing the branch name with the package name. The UiVersion component is now simpler and self-contained, fetching its data from build-time environment variables. The changes are applied consistently across all relevant files. I have one suggestion to further improve the robustness of the generated HTML id in the UiVersion component by sanitizing the package name. This will ensure compatibility with CSS selectors and testing frameworks without requiring character escaping.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4677 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 480 480
Lines 9078 9078
Branches 2195 2197 +2
=======================================
Hits 7905 7905
- Misses 1107 1108 +1
+ Partials 66 65 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replace branch with pkg name in UI version
Summary by Sourcery
Replace branch-based UI version identifier with package name and simplify UiVersion component usage across projects
Enhancements: