Adding ISNI as a Source #245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added downloader.
- Implement ISNIDownloader that fixes JSON-LD structure issues: - Removes control characters (\x1e, \x1f, \x1d) that break JSON parsing - Converts array of separate JSON-LD objects to single proper JSON-LD document - Consolidates multiple @context definitions into one - Combines all @graph entities into a single array - Maintains original data format while making it parseable by standard JSON-LD libraries - Compatible with actual BaseDownloader interface (overrides process method) - Add comprehensive test workflow that validates the complete pipeline - Successfully tested with real ISNI data: 1.8M records → 5.5M entities - Achieves 7% file size reduction while fixing structure
…memory. mapper is now built and ready for testing.
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ISNI as a new source in Lux. This PR's mapper allows you to map individual records to Lux from ISNI. To get the data in the correct format, however, you will want to look at the downloader, which handles converting the ISNI JSONLD format into standard JSONLD while also trimming down the data to the core components necessary. This also reduces the file size from 20Gb to ~13GB for people, for example.