NCL-9441 - Disable brew if only pnc lookup wanted#1616
NCL-9441 - Disable brew if only pnc lookup wanted#1616PolacekTomas wants to merge 2 commits intoproject-ncl:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1616 +/- ##
============================================
- Coverage 54.71% 54.34% -0.37%
Complexity 703 703
============================================
Files 51 51
Lines 4178 4208 +30
Branches 540 547 +7
============================================
+ Hits 2286 2287 +1
- Misses 1635 1664 +29
Partials 257 257 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@PolacekTomas The intention was not to have to add a new option, but to remove "build-systems" : [ "pnc", "koji" ],to "build-systems" : [ "pnc" ],although it's true that the code to implement this is missing. There's already a clear on lines build-finder/core/src/main/java/org/jboss/pnc/build/finder/core/BuildFinder.java Lines 1390 to 1391 in a6f16c8 so I wonder if we change just line to } else if (config.getBuildSystems().contains(BuildSystem.koji) {and surround lines build-finder/core/src/main/java/org/jboss/pnc/build/finder/core/BuildFinder.java Lines 1336 to 1362 in a6f16c8 with if (config.getBuildSystems().contains(BuildSystem.koji) {
}as well. Hopefully, this is a simpler way to implement this by using the existing |
No description provided.