Skip to content

[NCLSUP-1470] - Use archiveId as name if artifactId missing for win a… #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polacektomas merged 2 commits into from
Aug 18, 2026
Merged

[NCLSUP-1470] - Use archiveId as name if artifactId missing for win a… #1094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbd286e
[NCLSUP-1470] - Use archiveId as name if artifactId missing for win a…
Aug 18, 2026
f64fedd
[NCLSUP-1470] Remap 404 url input to an exception with a failed status
Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/main/java/org/jboss/pnc/deliverablesanalyzer/FileChecksumProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,11 @@ private RuntimeException mapToReasonedException(Exception e, String inputPath) {
"Invalid input URI: " + inputPath,
"Please check the URL.",
ce);
case IOException ioe -> new ReasonedException(
ResultStatus.FAILED,
"Invalid input URI: " + inputPath,
"Failed to download file. Please check the URL.",
ioe);
// Default to System Error for everything else
case null, default ->
new ReasonedException(ResultStatus.SYSTEM_ERROR, "System failed to process input: " + inputPath, e);
Expand Down
4 changes: 3 additions & 1 deletion ...va/org/jboss/pnc/deliverablesanalyzer/model/analyzer/artifact/AnalyzerArtifactMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,9 @@ public static AnalyzerArtifact mapFromKojiArchive(
}
case win -> {
WindowsAnalyzerArtifact win = new WindowsAnalyzerArtifact();
win.setName(archiveInfo.getArtifactId());
String name = archiveInfo.getArtifactId() != null ? archiveInfo.getArtifactId()
: archiveInfo.getArchiveId().toString();
win.setName(name);
String release = (buildDetails != null && buildDetails.getInfo() != null
&& buildDetails.getInfo().getRelease() != null) ? buildDetails.getInfo().getRelease()
: "unknown";
Expand Down