Support Gradle 9.1.0. Update nmcp.#513
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 80.26% 80.26%
=======================================
Files 42 42
Lines 2600 2600
Branches 356 356
=======================================
Hits 2087 2087
Misses 383 383
Partials 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dwalluck
reviewed
Oct 1, 2025
Comment on lines
+640
to
+641
| if (GradleVersion.current() >= GradleVersion.version("8.3") ) | ||
| { |
Contributor
There was a problem hiding this comment.
Slight formatting issue here?
Contributor
Author
There was a problem hiding this comment.
Hmmm. You're right, whats surprising is I thought spotless would have caught it but I've just realised we're not applying spotless to the gradle files.
Contributor
Author
There was a problem hiding this comment.
Ok so I could apply spotless using something like
kotlinGradle {
ktfmt().googleStyle().configure {
However, this will create a larger set of changes, I'll move that to a separate PR and ignore this for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.