Skip to content

Update Atlas and PME#516

Merged
rnc merged 4 commits into
project-ncl:mainfrom
rnc:PME-DEPS
Nov 17, 2025
Merged

Update Atlas and PME#516
rnc merged 4 commits into
project-ncl:mainfrom
rnc:PME-DEPS

Conversation

@rnc

@rnc rnc commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Requires project-ncl/pom-manipulation-ext#1076 merged first.

General comments:

  • Atlas changed its package structure (from org.commonjava.maven.atlas.ident.ref to org.commonjava.atlas.maven.ident.ref
  • We have to exclude logback as other dependent components use the 1.5.x line but that is JDK11. We override back to the 1.3.x line.
  • PME's FileIO no longer relies upon Galley (as that is JDK11).
    • Also exclude Galley from inclusion as GME doesn't use it and its JDK11
  • PME has migrated groupId (from org.commonjava.maven.ext to org.jboss.pnc.maven-manipulator)
  • Updated Sonatype snapshot URL
  • Shadow jar configuration:

@rnc rnc force-pushed the PME-DEPS branch 6 times, most recently from a440f17 to dd55667 Compare November 13, 2025 17:02
@codecov

codecov Bot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.72%. Comparing base (c90170e) to head (bb687ab).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/org/jboss/gm/common/utils/GroovyUtils.java 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
+ Coverage   80.26%   80.72%   +0.45%     
==========================================
  Files          42       42              
  Lines        2600     2599       -1     
  Branches      356      357       +1     
==========================================
+ Hits         2087     2098      +11     
+ Misses        383      374       -9     
+ Partials      130      127       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rnc rnc marked this pull request as ready for review November 14, 2025 09:39
@rnc rnc merged commit 99d684f into project-ncl:main Nov 17, 2025
82 of 84 checks passed
@rnc rnc deleted the PME-DEPS branch November 17, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant