[NCL-9527] Add support for LDAP authentication when receiving requests#362
Open
thescouser89 wants to merge 1 commit intoproject-ncl:masterfrom
Open
[NCL-9527] Add support for LDAP authentication when receiving requests#362thescouser89 wants to merge 1 commit intoproject-ncl:masterfrom
thescouser89 wants to merge 1 commit intoproject-ncl:masterfrom
Conversation
Author
|
I know @michalovjan , I am now the guy who creates big PRs :( sorry about that! |
thescouser89
force-pushed
the
ncl-9527
branch
2 times, most recently
from
3cb0a3c to
b606b08
Compare
This commit introduces breaking changes. Instead of providing the `-keycloakOfflineConfig` or `-keycloakConfig` option, only the new `-authHeaderConfig` is now supported. This new config requires the user to specify both the OIDC server details and LDAP server details (for Basic LDAP auth). The `auth-server-url` url now also requires to be the full url. For example for a keycloak server, it should now be: ``` https://server.com/auth/realms/realm ``` instead of ``` https://server.com/auth ``` This is to support any OIDC server rather than only Keycloak. A future commit will be created to support LDAP authentication when pnc-build-agent sends requests to other services.
thescouser89
force-pushed
the
ncl-9527
branch
from
b606b08 to
56b4fdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces breaking changes. Instead of providing the
-keycloakOfflineConfigor-keycloakConfigoption, only the new-authHeaderConfigis now supported.This new config requires the user to specify both the OIDC server details and LDAP server details (for Basic LDAP auth).
The
auth-server-urlurl now also requires to be the full url. For example for a keycloak server, it should now be:instead of
This is to support any OIDC server rather than only Keycloak. For example, another OIDC server's format url can be: https://server.com/blabla/realm/howaboutthis .
A future commit will be created to support LDAP authentication when pnc-build-agent sends requests to other services.