Refactoring: Improve naming of SessionsTracker method #2751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reproducibility Index: Reproducibility Index diff: diff --git a/reproducibility_index b/reproducibility_index
index a80dc95..dac86b6 100644
--- a/reproducibility_index
+++ b/reproducibility_index
@@ -1,2 +1,2 @@
-52842a915428bbe80690b5edd3573b6258e9fca6acb9b059e4ba1e992f12f353 ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_base
-0d2c2dfe6ffb2e1fa0bda4763c183112e6c1300bf3cbe43aeb1a696841c97f91 ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_unsafe
+d045d213bdb5162eeb5bb2b47158d0eb996978abd5a5b6582468407b91bb89d3 ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_base
+0e00e6b4cc33d62a99b3b4d2cad25de4c1551d79fd667e4d58207284319c18d9 ./target/x86_64-unknown-linux-musl/release/oak_functions_loader_unsafe
|
jul-sh
pushed a commit
that referenced
this pull request
Apr 22, 2022
* Extract session logic for remote attestion, GH issue ref #2741 * Move sessions logic into its own crate remove unused deps format oak-prefix crate name for consistency fix typo * Implement simple remote attestion for the UEFI app * remove unused dep * Update lockfile * Shutdown with UEFI error code if a remote attestation error occurs * Update method call to match #2751 * Remove erroneous mention of gRPC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses @conradgrobler's comment on #2742 #2742 (comment) to improve the clarity of naming.
Done in a separate PR as it's technically refactoring of other code; will rebase #2742 after this is merged.