Change visibility of Slab::root to public#229
Open
wootmatt wants to merge 2 commits intoproject-serum:masterfrom
Open
Change visibility of Slab::root to public#229wootmatt wants to merge 2 commits intoproject-serum:masterfrom
wootmatt wants to merge 2 commits intoproject-serum:masterfrom
Conversation
|
Thanks! I ran into a variety of issues like this, and wound up having to mutably remove_max until empty, which is not ideal, even for off-chain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
Trying to walk down the
Slabin a specific order which is hard to do without having access toSlab::root. I don't see any harm in making said function public, so I changed the visibility.