functional test cases #120

kirtisagarksj · 2018-10-18T18:16:43Z

No description provided.

manzarul · 2018-10-19T11:33:44Z

...rces/templates/organisation/user/add/testAddUserToOrgFailureWithEmptyRoleArray/response.json

-        "errmsg": "Role of the user is required"
+        "err": "INVALID_USER_DATA",
+        "status": "INVALID_USER_DATA",
+        "errmsg": "Given User Data doesn't exist in our records. Please provide a valid one"


@kirtisagarksj this test is for empty role , so it should throw role error.

manzarul · 2018-10-19T11:35:24Z

...rvice_api_test/src/test/java/org/sunbird/integration/test/user/notes/DeleteUserNoteTest.java

@@ -80,7 +80,7 @@ public void testDeleteUserNoteSuccess(
  @CitrusTest
  public void testDeleteUserNoteFailureWithInvalidNoteId() {
    getTestCase().setName(TEST_DELETE_USER_NOTE_FAILURE_WITH_INVALID_NOTEID);
-    beforeTest();
+    //beforeTest();


why beforeTest(); is commented.

kirtisagarksj · 2018-10-21T11:51:34Z

beforeTest() is commented because the test is for Invalid NoteId. So we don`t need to call beforeTest to get note id

…

On Fri, Oct 19, 2018 at 5:05 PM manzarul Haque ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In sunbird_service_api_test/src/test/java/org/sunbird/integration/test/user/notes/DeleteUserNoteTest.java <#120 (comment)> : > @@ -80,7 +80,7 @@ public void testDeleteUserNoteSuccess( @citrustest public void testDeleteUserNoteFailureWithInvalidNoteId() { getTestCase().setName(TEST_DELETE_USER_NOTE_FAILURE_WITH_INVALID_NOTEID); - beforeTest(); + //beforeTest(); why beforeTest(); is commented. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#120 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AomXLrsqPaNaEVInPOPGVaUjdyh-vlr0ks5umbj9gaJpZM4XuT4W> .

manzarul · 2018-10-22T12:31:42Z

sunbird_service_api_test/src/test/java/org/sunbird/integration/test/org/AddUserToOrgTest.java

-  @Test(dataProvider = "addUserToOrgFailureDataProvider")
-  @CitrusParameters({"testName"})
+  @Test(dataProvider = "addUserToOrgDataProvider")
+  @CitrusParameters({"testName", "getUserId", "httpStatus"})


getUserId is used for which purpose

manzarul · 2018-10-22T12:35:32Z

...es/templates/organisation/read/testReadOrgSuccessWithValidProviderAndExternalId/request.json

@@ -1,5 +1,6 @@
 {
  "request": {
+    "organisationId": "${organisationId}",


Why we always send "organisationId": "${organisationId}" is added in request.

manzarul · 2018-10-22T12:36:27Z

.../src/test/resources/templates/user/block/testBlockUserFailureWithInvalidUserId/response.json

@@ -5,10 +5,10 @@
    "params": {


Why user not found will be internal error.

bvinayakumar · 2018-10-23T07:13:11Z

sunbird_service_api_test/src/test/java/org/sunbird/integration/test/org/AddUserToOrgTest.java

 import org.sunbird.integration.test.common.BaseCitrusTestRunner;
 import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;

+import javax.ws.rs.core.MediaType;
+
 public class AddUserToOrgTest extends BaseCitrusTestRunner {

  public static final String TEST_ADD_USER_TO_ORG_FAILURE_WITH_EMPTY_ROLE_ARRAY =


Constant name and value don't correspond.

bvinayakumar · 2018-10-23T07:14:17Z

sunbird_service_api_test/src/test/java/org/sunbird/integration/test/org/AddUserToOrgTest.java

  @CitrusTest
-  public void testAddUserToOrgFailure(String testName) {
+  public void testAddUserToOrgFailure(String testName, boolean getUserId, HttpStatus httpStatus) {


Test name and data provider name mismatch.

bvinayakumar · 2018-10-23T07:17:07Z

sunbird_service_api_test/src/test/java/org/sunbird/integration/test/user/BlockUserTest.java

@@ -32,7 +32,7 @@ private String getBlockUserUrl() {

    return new Object[][] {
      new Object[] {TEST_BLOCK_USER_FAILURE_WITHOUT_ACCESS_TOKEN, false, HttpStatus.UNAUTHORIZED},
-      new Object[] {TEST_BLOCK_USER_FAILURE_WITH_INVALID_USERID, true, HttpStatus.NOT_FOUND},
+      new Object[] {TEST_BLOCK_USER_FAILURE_WITH_INVALID_USERID, true, HttpStatus.INTERNAL_SERVER_ERROR},


Why does invalid user ID result in internal server error?

bvinayakumar · 2018-10-23T07:18:10Z

...rd_service_api_test/src/test/java/org/sunbird/integration/test/user/GetUserByUserIdTest.java

@@ -92,7 +92,7 @@ public void testGetBlockUserByUserIdFailure() {
  }

  private void blockUser() {
-    UserUtil.blockUser(this, TEMPLATE_DIR_BLOCK, TEST_BA_BLOCK_USER_SUCCESS_WITH_VALID_USERID);
+    UserUtil.blockUser(this, TEMPLATE_DIR, "testGetUserByUserIdFailureWithBlockedUser");


Why failure request templates passed to block user method?

bvinayakumar · 2018-10-23T07:18:33Z

sunbird_service_api_test/src/test/java/org/sunbird/integration/test/user/UnblockUserTest.java

@@ -42,15 +42,15 @@ private String getUnblockUserUrl() {

    return new Object[][] {
      new Object[] {TEST_UNBLOCK_USER_FAILURE_WITHOUT_ACCESS_TOKEN, false, HttpStatus.UNAUTHORIZED},
-      new Object[] {TEST_UNBLOCK_USER_FAILURE_WITH_INVALID_USERID, true, HttpStatus.NOT_FOUND},
+      new Object[] {TEST_UNBLOCK_USER_FAILURE_WITH_INVALID_USERID, true, HttpStatus.INTERNAL_SERVER_ERROR},


Why does invalid user ID result in internal server error?

bvinayakumar · 2018-10-23T07:19:03Z

sunbird_service_api_test/src/test/java/org/sunbird/integration/test/user/UnblockUserTest.java

    };
  }

  @DataProvider(name = "unblockUserSuccessDataProvider")
  public Object[][] unblockUserSuccessDataProvider() {

    return new Object[][] {
-      new Object[] {TEST_UNBLOCK_USER_SUCCESS_WITH_VALID_USERID, true, HttpStatus.OK},
+      new Object[] {TEST_UNBLOCK_USER_SUCCESS_WITH_VALID_USERID, true, HttpStatus.INTERNAL_SERVER_ERROR},


Why does success test result in internal server error?

bvinayakumar · 2018-10-23T07:19:36Z

...ervice_api_test/src/test/java/org/sunbird/integration/test/user/UpdateUserLoginTimeTest.java

-      new Object[] {TEST_UPDATE_USER_LOGIN_TIME_SUCCESS_WITH_INVALID_USER_ID, true, HttpStatus.OK},
-    };
-  }
+        return new Object[][]{


Format code properly.

bvinayakumar · 2018-10-23T07:20:09Z

...pi_test/src/test/java/org/sunbird/integration/test/user/UpdateUserProfileVisibilityTest.java

      },
      new Object[] {
-        TEST_UPDATE_USER_PROFILE_VISIBILITY_FAILURE_WITH_INVALID_USERID, true, HttpStatus.NOT_FOUND
+        TEST_UPDATE_USER_PROFILE_VISIBILITY_FAILURE_WITH_INVALID_USERID, true, HttpStatus.BAD_REQUEST, false


Why does invalid user ID result in bad request? Not found is more relevant.

bvinayakumar · 2018-10-23T07:21:24Z

...test/resources/templates/organisation/search/testSearchOrgFailureWithoutFilter/response.json

+        "err":"MANDATORY_PARAMETER_MISSING",
+        "status":"MANDATORY_PARAMETER_MISSING",
+        "errmsg":"Mandatory parameter filters is missing."
+=======


Unresolved merge conflict is being pushed !

functional test cases

7d04fce

manzarul reviewed Oct 19, 2018

View reviewed changes

remaining functional test cases

334a77e

manzarul reviewed Oct 22, 2018

View reviewed changes

Kirti Jenamoni and others added 2 commits October 22, 2018 18:53

conflit solved

220e83b

remaining finished

1a983c4

bvinayakumar reviewed Oct 23, 2018

View reviewed changes

manzarul changed the base branch from release-1.12 to release-2.0.0 July 12, 2019 04:51

manzarul changed the base branch from release-2.0.0 to master July 12, 2019 04:52

manzarul changed the base branch from master to release-2.0.0 July 12, 2019 04:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

functional test cases #120

functional test cases #120

kirtisagarksj commented Oct 18, 2018

manzarul Oct 19, 2018

manzarul Oct 19, 2018

kirtisagarksj commented Oct 21, 2018 via email

manzarul Oct 22, 2018

manzarul Oct 22, 2018

manzarul Oct 22, 2018

bvinayakumar Oct 23, 2018

bvinayakumar Oct 23, 2018

bvinayakumar Oct 23, 2018

bvinayakumar Oct 23, 2018

bvinayakumar Oct 23, 2018

bvinayakumar Oct 23, 2018

bvinayakumar Oct 23, 2018

bvinayakumar Oct 23, 2018

bvinayakumar Oct 23, 2018

functional test cases #120

Are you sure you want to change the base?

functional test cases #120

Conversation

kirtisagarksj commented Oct 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kirtisagarksj commented Oct 21, 2018 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment