Skip to content

Refactor end2end #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jonathanvila wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Refactor end2end #112

jonathanvila wants to merge 32 commits into from

Conversation

@jonathanvila
Copy link
Member

@jonathanvila jonathanvila commented Jun 4, 2020

Refactoring EndToEndTest in order to be able to have individual tests and a unique point of infra creation with TestContainers

Things to consider :

  • tests are not order guaranteed so we need to think on the tests as in isolation
  • every test needs to check the condition without expecting other tests have populated info

jonathan added 25 commits May 28, 2020 20:28
refactor end to end
2efd70c
cleaned changes from other branch
7d56e6c
refactor-end2end deleted @ignore on endtoend tests
9c63a39
Merge branch 'master' of https://github.com/project-xavier/xavier-int…
b97d881 
…egration into refactor-end2end
refactor-end2end organized imports
5dcecab
refactor-end2end Fixed test
d9b2242
Merge branch 'master' of https://github.com/project-xavier/xavier-int…
0db2a1e 
…egration into refactor-end2end
Merge branch 'master' of https://github.com/project-xavier/xavier-int…
e909da0 
…egration into refactor-end2end
refactor_endtoend fix tests
b301ca7
refactor Fixed asserts on S3Objects
b0b38eb
Merge branch 'master' of https://github.com/project-xavier/xavier-int…
bb676b7 
…egration into refactor-end2end
Merge branch 'master' of https://github.com/project-xavier/xavier-int…
72c1ad0 
…egration into refactor-end2end
refactor-end2end Added awaitility code to be sure the resources are c…
dbc1827 
…reated
refactor-end2end starting and stopping camel context
8c24dd4
endtoend refactor - fixed RBAC tests on the duplicated SpringBootTest…
cc375d4 
… annotation

numAnalysis is set at the current number of analisys in the DB
refactor-endtoend upgraded testcontainers version
75a0d63
refactor-end2end restructure of EndToEndTest and creation of a separa…
29d43cb 
…te class with Docker infrastructure
refactor-end2end Split the start of containers in 3 groups and indivi…
81b3b88 
…duals
refactor-end2end modified travis in order to only execute endtoendtes…
a90abe3 
…t to see the time
refactor-end2end ensuring info is captured before deleting
b229bd3
end2end refactor Split startup of containers
f437b5b
endtoend refactor removed @ignore
d8af74e
refactor All containers started in sequence
7b1bed3
endtoend refator - adding an await until summaryreport is done on the…
edcebb3 
… delete test
endtoend refactor - removed constraint on tests to execute on travis
6fd6bd3
@jonathanvila
Copy link
Member Author

jonathanvila commented Jul 22, 2020

retest

@jonathanvila jonathanvila added the Ready for review The PR is ready to be reviewed label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-brophy m-brophy Awaiting requested review from m-brophy

Assignees

No one assigned

Labels

Ready for review The PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonathanvila