Skip to content

Conversation

@hown3d
Copy link

@hown3d hown3d commented Feb 14, 2025

What type of PR is this?
feature

Which issue does this PR fix:
#2752

What does this PR do / Why do we need it:
redirects clients to a presigned urls for blob downloads, which significantly reduces load of the zot server, since the blobs no longer need to go through the server.

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

redirect clients to S3 URLs when fetching blobs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hown3d
Copy link
Author

hown3d commented Feb 14, 2025

Certain aspects are not covered yet:

  • handling nested StorageConfig.DisableRedirects from config (just global is used)

@rchincha
Copy link
Contributor

opencontainers/distribution-spec#299

@hown3d would also show your support upstream.
zot plays a "follower" role to Open Containers specs.

@zer010gic
Copy link

Is there any news on whether this PR/Feature will be implemented?

@github-actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@andaaron
Copy link
Contributor

Assuming the spec allows for 307, what is the expected behavior for auth? The website we redirect to may have authentication.

@joshbwlng
Copy link

joshbwlng commented Dec 15, 2025

@andaaron From what I understand, presigned URLs shouldn't have auth issues because they're presigned and only valid for a short period of time. I suppose we could potentially handle this in a download redirect proxy running in front of Zot, but it would make more sense in my opinion for it to be implemented within Zot itself - like it is for docker distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants