refactor: remove usage of goto in the image store

[andaaron]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (88efa50) to head (aa20fcd).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2969   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files         174      174           
  Lines       32666    32667    +1     
=======================================
+ Hits        29747    29748    +1     
  Misses       2207     2207           
  Partials      712      712           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rchincha]

lgtm

but why make this change at all?

[andaaron]

Because it was very confusing for me as a developer reading the code.
I was troubleshooting an issue related to some of the calls made from this function, and it took me over an hour to notice we had a loop and those functions were called multiple times.

In any case don't merge this. I prefer to proceed with the PR also handling the locks.