Skip to content

[feat] support custom GitHub OAuth2 auth and token URLs #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

analytically
Copy link

Feature

Which issue does this PR fix:

Support custom Github OAuth2 auth and token URLs

Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, can you also add an example configuration under https://github.com/project-zot/zot/tree/main/examples?

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.95%. Comparing base (c87f489) to head (fd87859).

Files with missing lines Patch % Lines
pkg/api/authn.go 50.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3024      +/-   ##
==========================================
- Coverage   90.96%   90.95%   -0.02%     
==========================================
  Files         176      176              
  Lines       32940    32951      +11     
==========================================
+ Hits        29965    29970       +5     
- Misses       2245     2249       +4     
- Partials      730      732       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andaaron
Copy link
Contributor

@analytically can you also add a test to verify the new configuration?

@analytically
Copy link
Author

@andaaron a test that runs against GitHub Enterprise? Or just config object validation?

@andaaron
Copy link
Contributor

I was thinking maybe we could mock it, similar to what we have in

func MockOIDCRun() (*mockoidc.MockOIDC, error) {

@rchincha
Copy link
Contributor

Support custom Github OAuth2 auth and token URLs

^ could you also point to pointers/docs about why this PR is needed.

@analytically thanks for taking the time for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants