-
Notifications
You must be signed in to change notification settings - Fork 131
[feat] support custom GitHub OAuth2 auth and token URLs #3024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR, can you also add an example configuration under https://github.com/project-zot/zot/tree/main/examples?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3024 +/- ##
==========================================
- Coverage 90.96% 90.95% -0.02%
==========================================
Files 176 176
Lines 32940 32951 +11
==========================================
+ Hits 29965 29970 +5
- Misses 2245 2249 +4
- Partials 730 732 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fd87859
to
1be557a
Compare
@analytically can you also add a test to verify the new configuration? |
@andaaron a test that runs against GitHub Enterprise? Or just config object validation? |
I was thinking maybe we could mock it, similar to what we have in Line 13 in c87f489
|
^ could you also point to pointers/docs about why this PR is needed. @analytically thanks for taking the time for this PR. |
Feature
Which issue does this PR fix:
Support custom Github OAuth2 auth and token URLs