feat: add conda build support with configuration and scripts #3544
+385
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramkumar Chinchani <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3544 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 185 185
Lines 25852 25852
=======================================
Hits 23699 23699
Misses 1392 1392
Partials 761 761 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andaaron
reviewed
Nov 15, 2025
|
|
||
| # Go compiler version | ||
| go: | ||
| - 1.22 |
| - conda-forge | ||
| - defaults | ||
| dependencies: | ||
| - go >=1.22 |
Contributor
There was a problem hiding this comment.
Suggested change
| - go >=1.22 | |
| - go >=1.24.4 |
| requirements: | ||
| build: | ||
| - {{ compiler('go') }} | ||
| - go >=1.22 |
Contributor
There was a problem hiding this comment.
go 1.22 is in 3 places, where did it pick it from?
| {% set version = environ.get('RELEASE_TAG', 'dev').lstrip('v') %} | ||
| {% set commit = environ.get('COMMIT', 'unknown') %} | ||
| {% set go_version = environ.get('GO_VERSION', 'unknown') %} | ||
| {% set build_labels = environ.get('BUILD_LABELS', 'sync,search,scrub,metrics,lint,ui,mgmt,profile,userprefs,imagetrust,events') %} |
Contributor
There was a problem hiding this comment.
For UI you need to get the UI build and untar it in a specific folder, see our makefile
| script: | ||
| - export CGO_ENABLED=0 | ||
| - export GOOS={{ environ.get('GOOS', target_platform.split('-')[0]) }} | ||
| - export GOARCH={{ environ.get('GOARCH', target_platform.split('-')[1]) }} |
| bench: modcheck build-metadata | ||
| env CGO_ENABLED=0 GOOS=$(OS) GOARCH=$(ARCH) go build -o bin/zb-$(OS)-$(ARCH)$(BIN_EXT) $(BUILDMODE_FLAGS) $(GO_CMD_TAGS) -v -trimpath -ldflags "-X $(CONFIG_COMMIT)=${COMMIT} -X $(CONFIG_BINARY_TYPE)=$(extended-name) -X $(CONFIG_GO_VERSION)=${GO_VERSION} -s -w" ./cmd/zb | ||
|
|
||
| .PHONY: check-conda |
Contributor
There was a problem hiding this comment.
Can we define these in a separate makefile? This is getting cluttered.
| requirements: | ||
| build: | ||
| - {{ compiler('go') }} | ||
| - go >=1.22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.